Add support to parse and return the GardenLinux "cname" #98
Conversation
NotTheEvilOne
force-pushed
the
feature/support-cname-parser
branch
4 times, most recently
from
baa8f2d to
431a6cc
Compare
NotTheEvilOne
force-pushed
the
feature/support-cname-parser
branch
from
431a6cc to
1658ac1
Compare
| import re | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
Just for your reference, we also have the python-gardenlinux-cli, which is used as a CLI wrapper for this library.
There was a problem hiding this comment.
... at least this was the initial intention. :D
not sure how to design this now, since python-gardenlinux-cli looks more like a tool for OCI only.
There was a problem hiding this comment.
I'm not sure if adding a separate CLI repository may not be counter productive as reusability of code between "lib" and "cli" parts are at least more complicated in that case. Naming of both repositories may be changed to reflect there content.
Furthermore GardenLinux does not have a Python code base that allows "lib" code to be used without a "cli" implementation. Therefore I would suggest to unify the code paths in place.
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
I am fine with extending python-gardenlinux-lib and getting rid of python-gardenlinux-cli (I think @paulphys mentioned this).
Maybe another approach would be deprecating old code somehow (at least comment it inside the code) as we have duplicate code in this library already. Also identifying where this is actually used and where we can break things.
Relates: gardenlinux/gardenlinux#2830 Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
feature/support-cname-parser
branch
3 times, most recently
from
836b73e to
51712b3
Compare
NotTheEvilOne
force-pushed
the
feature/support-cname-parser
branch
from
51712b3 to
b48ffe0
Compare
What this PR does / why we need it:
This PR adds
gl-cnameas a script to parse and return the cname based on thefeaturesdirectory. It does not refactor the underlying code base even though many functions defined contain duplicated code.Which issue(s) this PR fixes:
Relates gardenlinux/gardenlinux#2830